[PATCH for 7.4.0 v2 0/3] Avoid double indentation of <metadata/> element

Michal Prívozník mprivozn at redhat.com
Tue May 25 11:19:46 UTC 2021

On 5/25/21 12:12 PM, Pavel Hrdina wrote:
> On Tue, May 25, 2021 at 11:57:39AM +0200, Michal Prívozník wrote:
>> On 5/25/21 11:48 AM, Michal Privoznik wrote:
>> Meanwhile, this was fixed in libxml2's upstream:
>> https://gitlab.gnome.org/GNOME/libxml2/-/commit/13ad8736d294536da4cbcd70a96b0a2fbf47070c
>> So I guess there won't be any regression with any upstream release of
>> libxml2. But as I pointed out in v1, some distros are known to already
>> backport the problematic patch (Fedora and Gentoo) so the question is
>> how likely they are to backport the fix too. I still think it's worth
>> fixing on our side.
> I'm not sure if it's worth fixing, on one hand libvirt tests would be
> broken, on the other hand running libvirt tests could detect the broken
> backport and help others to create bug reports to backport the fix as
> well.

I hear you but also, if we want to freeze anytime soon we should have
green pipeline :-)

And also, we already have precedence of working around broken libraries
in our code. Remember glib and all the fun we were having?

> Anyway, for the code
> Reviewed-by: Pavel Hrdina <phrdina at redhat.com>

Pushed, thank you.


More information about the libvir-list mailing list