[PATCH] qemuDomainAttachDiskGenericTransient: Add NULL check in case the overlay disk already exists

Ján Tomko jtomko at jtomko.net
Thu May 27 07:44:59 UTC 2021


On a Wednesday in 2021, Masayoshi Mizuma wrote:
>From: Masayoshi Mizuma <m.mizuma at jp.fujitsu.com>
>
>When <transient shareBacking='yes'> is set to a disk and the overlay
>disk already exists because of something abnormal, libvirt is terminated
>by Segmentation fault.
>
>  # virsh start Test0
>  error: Disconnected from qemu:///system due to end of file
>  error: Failed to start domain 'Test0'
>  error: End of file while reading data: Input/output error
>
>Add NULL check for snapdiskdef so that the rollback can work correctly.
>
>Signed-off-by: Masayoshi Mizuma <m.mizuma at jp.fujitsu.com>
>---
> src/qemu/qemu_hotplug.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20210527/c10ae032/attachment-0001.sig>


More information about the libvir-list mailing list