[libvirt PATCH 1/2] Partial Revert of "tests: nodedevxml2xmltest: test more mdev files"

[Michal Prívozník]

On 5/26/21 5:40 PM, Jonathon Jongsma wrote:
> This reverts parts of commit bb8c3b61208ed0f29dcbeca857529600f04b3146
> that added tests for autostart functionality (which will be reverted in
> the following commit)
> ---
>  tests/nodedevschemadata/mdev_autostart.xml            | 10 ----------
>  tests/nodedevschemadata/mdev_manual.xml               | 10 ----------
>  tests/nodedevxml2xmlout/mdev_autostart.xml            | 11 -----------
>  .../mdev_d069d019_36ea_4111_8f0a_8c9a70e21366.xml     |  1 -
>  .../mdev_d2441d39_495e_4243_ad9f_beb3f14c23d9.xml     |  1 -
>  .../mdev_fedc4916_1ca8_49ac_b176_871d16c13076.xml     |  1 -
>  tests/nodedevxml2xmlout/mdev_manual.xml               | 11 -----------
>  tests/nodedevxml2xmltest.c                            |  2 --
>  8 files changed, 47 deletions(-)
>  delete mode 100644 tests/nodedevschemadata/mdev_autostart.xml
>  delete mode 100644 tests/nodedevschemadata/mdev_manual.xml
>  delete mode 100644 tests/nodedevxml2xmlout/mdev_autostart.xml
>  delete mode 100644 tests/nodedevxml2xmlout/mdev_manual.xml

> diff --git a/tests/nodedevxml2xmlout/mdev_d069d019_36ea_4111_8f0a_8c9a70e21366.xml b/tests/nodedevxml2xmlout/mdev_d069d019_36ea_4111_8f0a_8c9a70e21366.xml
> index bff95b015b..4f9d491981 100644
> --- a/tests/nodedevxml2xmlout/mdev_d069d019_36ea_4111_8f0a_8c9a70e21366.xml
> +++ b/tests/nodedevxml2xmlout/mdev_d069d019_36ea_4111_8f0a_8c9a70e21366.xml
> @@ -4,7 +4,6 @@
>    <capability type='mdev'>
>      <type id='i915-GVTg_V5_8'/>
>      <uuid>d069d019-36ea-4111-8f0a-8c9a70e21366</uuid>
> -    <start type='manual'/>

This ..

>      <iommuGroup number='0'/>
>    </capability>
>  </device>
> diff --git a/tests/nodedevxml2xmlout/mdev_d2441d39_495e_4243_ad9f_beb3f14c23d9.xml b/tests/nodedevxml2xmlout/mdev_d2441d39_495e_4243_ad9f_beb3f14c23d9.xml
> index beb25b1989..1aa0afe085 100644
> --- a/tests/nodedevxml2xmlout/mdev_d2441d39_495e_4243_ad9f_beb3f14c23d9.xml
> +++ b/tests/nodedevxml2xmlout/mdev_d2441d39_495e_4243_ad9f_beb3f14c23d9.xml
> @@ -3,7 +3,6 @@
>    <parent>pci_0000_00_02_0</parent>
>    <capability type='mdev'>
>      <type id='i915-GVTg_V5_8'/>
> -    <start type='manual'/>

and this ...

>      <iommuGroup number='0'/>
>      <attr name='example-attribute-1' value='attribute-value-1'/>
>      <attr name='example-attribute-2' value='attribute-value-2'/>
> diff --git a/tests/nodedevxml2xmlout/mdev_fedc4916_1ca8_49ac_b176_871d16c13076.xml b/tests/nodedevxml2xmlout/mdev_fedc4916_1ca8_49ac_b176_871d16c13076.xml
> index 1d6dbb6118..da2a702304 100644
> --- a/tests/nodedevxml2xmlout/mdev_fedc4916_1ca8_49ac_b176_871d16c13076.xml
> +++ b/tests/nodedevxml2xmlout/mdev_fedc4916_1ca8_49ac_b176_871d16c13076.xml
> @@ -3,7 +3,6 @@
>    <parent>pci_0000_00_02_0</parent>
>    <capability type='mdev'>
>      <type id='i915-GVTg_V5_8'/>
> -    <start type='manual'/>

.. and this needs to stay and should be removed in the next commit,
because otherwise xml2xml test fails. Rightfully, as the input XMLs
still have them. I'll fix that before pushing.

>      <iommuGroup number='0'/>
>      <attr name='example-attribute' value='attribute-value'/>
>    </capability>

Michal