[PATCH 0/7] Misc g_auto() rewrites

Michal Privoznik mprivozn at redhat.com
Mon Nov 1 14:16:12 UTC 2021


I've been looking at our tests lately and noticed an opportunity to
rewrite pieces of code to g_auto() magic.

Michal Prívozník (7):
  qemuagenttest: Don't leak virTypedParameter on failure
  Prefer g_auto(GStrv) over g_strfreev()
  qemu: Use g_autoptr(qemuMonitorCPUModelInfo)
  qemuConnectStealCPUModelFromInfo: Drop needless 'cleanup' label
  tests: Use g_autoptr(qemuMonitorTest)
  test: Use g_autofree more
  tests: Drop cleanup/error labels

 src/bhyve/bhyve_command.c           |   3 +-
 src/bhyve/bhyve_parse_command.c     |  22 +--
 src/libxl/libxl_conf.c              |   9 +-
 src/libxl/xen_common.c              |  18 +-
 src/libxl/xen_xl.c                  |  17 +-
 src/lxc/lxc_container.c             |   4 +-
 src/lxc/lxc_native.c                |  24 +--
 src/qemu/qemu_driver.c              |  17 +-
 src/remote/remote_daemon_dispatch.c |   3 +-
 src/remote/remote_driver.c          |   4 +-
 src/storage/storage_backend_rbd.c   |   3 +-
 src/util/vircgroup.c                |   3 +-
 src/util/vircgroupv2.c              |   4 +-
 src/util/virfirmware.c              |   6 +-
 src/util/viruri.c                   |   3 +-
 src/vbox/vbox_common.c              |  12 +-
 src/vbox/vbox_snapshot_conf.c       |  40 ++--
 src/vbox/vbox_tmpl.c                |   3 +-
 src/vz/vz_sdk.c                     |   3 +-
 tests/qemuagenttest.c               | 286 ++++++++++++----------------
 tests/qemucapabilitiestest.c        |  22 +--
 tests/qemuhotplugtest.c             |   3 +-
 tests/qemumigparamstest.c           |  40 ++--
 tests/qemumonitorjsontest.c         |  95 ++++-----
 tests/qemumonitortestutils.c        |  63 +++---
 tests/vboxsnapshotxmltest.c         |   3 +-
 tests/virconftest.c                 |   3 +-
 tests/virfiletest.c                 |   3 +-
 tests/virstringtest.c               |   3 +-
 tools/virsh-host.c                  |  13 +-
 tools/virt-login-shell-helper.c     |   7 +-
 tools/vsh.c                         |   4 +-
 32 files changed, 279 insertions(+), 464 deletions(-)

-- 
2.32.0




More information about the libvir-list mailing list