[PATCH] virsh: Fix ambiguous output in metadata-change event

Michal Prívozník mprivozn at redhat.com
Mon Nov 1 16:03:57 UTC 2021


On 10/27/21 10:52 AM, Han Han wrote:
> When you set metadata with type element like the following:
> dom.setMetadata(libvirt.VIR_DOMAIN_METADATA_ELEMENT, "<test/>", 'abc', "HAHAH", 0)
> 
> Then for `virsh event --all`, then it will output this message:
> event 'metadata-change' for domain 'rhel9': element HAHAH
> 
> The message is ambiguous since it looks like the params for
> metadata-change event is the element HAHAH. Actually that means the type is
> element while the url is HAHAH. Let's make it more clear.
> 
> Signed-off-by: Han Han <hhan at redhat.com>
> ---
>  tools/virsh-domain.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

Michal




More information about the libvir-list mailing list