[PATCH v2] qemu_block: Refactor qemuBlockExportAddNBD()

Michal Prívozník mprivozn at redhat.com
Mon Nov 1 16:09:37 UTC 2021


On 10/26/21 5:19 PM, Kristina Hanicova wrote:
> This is v2 of: https://listman.redhat.com/archives/libvir-list/2021-October/msg01035.html
> 
> Diff to v1:
> * negation of 'if' with switched body (proposed by Peter)
> 
> Signed-off-by: Kristina Hanicova <khanicov at redhat.com>
> ---
>  src/qemu/qemu_block.c | 33 +++++++++++++--------------------
>  1 file changed, 13 insertions(+), 20 deletions(-)

The patch is correct, but I think the commit message can be made
cleaner. We don't need a reference to older versions, but what I'd
appreciate is a short description (be it one sentence long) what's
happening in the commit. Can you please reply with something like that?
I'll update to commit message and push.

Michal




More information about the libvir-list mailing list