[PATCH 2/4] qemustatusxml2xmldata: backup-pull: Add private data for scratch image

[Nir Soffer]

On Mon, Nov 1, 2021 at 4:48 PM Peter Krempa <pkrempa at redhat.com> wrote:
>
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>  tests/qemustatusxml2xmldata/backup-pull-in.xml | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/tests/qemustatusxml2xmldata/backup-pull-in.xml b/tests/qemustatusxml2xmldata/backup-pull-in.xml
> index 95afd3a51f..59c934d4f7 100644
> --- a/tests/qemustatusxml2xmldata/backup-pull-in.xml
> +++ b/tests/qemustatusxml2xmldata/backup-pull-in.xml
> @@ -257,7 +257,14 @@
>        <server transport='tcp' tls='yes' name='localhost' port='10809'/>
>        <disks>
>          <disk name='vda' backup='yes' state='running' type='file' index='123'>
> -          <scratch file='/path/to/file/'/>
> +          <scratch file='/path/to/file/'>
> +            <privateData>
> +              <nodenames>
> +                <nodename type='storage' name='libvirt-1337-storage'/>
> +                <nodename type='format' name='libvirt-1337-format'/>

Shouldn't this be libvirt-123-*, matching the index=?

Since we have the index entry, and libvirt knows that it has
libvirt-N-storage and libvirt-N-format
for every disk, why do we need to keep this info?

Finally, is this exposed in backup-dumpxml?

> +              </nodenames>
> +            </privateData>
> +          </scratch>
>          </disk>
>        </disks>
>        <privateData>
> --
> 2.31.1
>