[PATCH v2 0/4] Introduce TCG domain features

Kashyap Chamarthy kchamart at redhat.com
Mon Nov 8 10:17:58 UTC 2021


On Fri, Nov 05, 2021 at 10:35:16AM +0100, Michal Privoznik wrote:
> v2 of:
> 
> https://listman.redhat.com/archives/libvir-list/2021-November/msg00143.html
> 
> diff to v1:
> - Patches 1/4 and 2/4 are new, per Dan's suggestion
> - Patch 4/4 was reworked, since after 2/4 we are using -accel
>  unconditionally

I've built from your branch:
https://gitlab.com/MichalPrivoznik/libvirt.git / tcg_tb_size_alt_v2.

(I also needed the other patch when testing from your branch:
"remote_daemon: Validate tcp_min_ssf value only if found in config").

So compiled with:

   $> git describe
   v7.9.0-94-gc39356148c

Still works fine for me.  Two quick tests:

(1) With only <domain type='qemu'>, libvirt now uses `-accel tcg`
    unconditionally.  (As opposed to `-machine accel`)

(2) And adding the `tb-cache` bit:

       <features>
         <tcg>
           <tb-cache unit='KiB'>65536</tb-cache>
         </tcg>
       </features>

    ... results in QEMU command-line: `-accel tcg,tb-size=64`

Series:

    Tested-by: Kashyap Chamarthy <kchamart at redhat.com>  

Thanks for the quick work!

-- 
/kashyap




More information about the libvir-list mailing list