[PATCH 3/9] qemu: don't bother saving ret code from qemuDomainSaveMemory

Nikolay Shirokovskiy nshirokovskiy at virtuozzo.com
Thu Nov 11 08:55:48 UTC 2021


It does not make a difference. qemuDomainSaveMemory ret code is either
0 or -1. If it is -1 then ret is already set to -1. If it is 0 then it
is overwritten by qemuSnapshotCreateActiveExternalDisks anyway.

Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy at virtuozzo.com>
---
 src/qemu/qemu_snapshot.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c
index aa9b2ebbd9..8656affa25 100644
--- a/src/qemu/qemu_snapshot.c
+++ b/src/qemu/qemu_snapshot.c
@@ -1451,9 +1451,9 @@ qemuSnapshotCreateActiveExternal(virQEMUDriver *driver,
 
         memory_existing = virFileExists(snapdef->memorysnapshotfile);
 
-        if ((ret = qemuSaveImageCreate(driver, vm, snapdef->memorysnapshotfile,
-                                       data, compressor, 0,
-                                       QEMU_ASYNC_JOB_SNAPSHOT)) < 0)
+        if (qemuSaveImageCreate(driver, vm, snapdef->memorysnapshotfile,
+                                data, compressor, 0,
+                                QEMU_ASYNC_JOB_SNAPSHOT) < 0)
             goto cleanup;
 
         /* the memory image was created, remove it on errors */
-- 
2.27.0




More information about the libvir-list mailing list