[PATCH 2/6] tools: Add virt-pki-query-dn binary

[Martin Kletzander]

On Thu, Nov 11, 2021 at 03:38:24PM +0000, Daniel P. Berrangé wrote:
>On Thu, Nov 11, 2021 at 04:06:42PM +0100, Martin Kletzander wrote:
>> With this program we do not have to depend on the output of `certtool -i`, which
>> changed the order of the fields at some point and the newest version is
>> incompatible with what libvirt expects in tls_allowed_dn_list configuration
>> option.
>>
>> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>> ---
>>  libvirt.spec.in           |   1 +
>>  po/POTFILES.in            |   1 +
>>  tools/meson.build         |  26 ++++++++
>>  tools/virt-pki-query-dn.c | 137 ++++++++++++++++++++++++++++++++++++++
>>  4 files changed, 165 insertions(+)
>>  create mode 100644 tools/virt-pki-query-dn.c
>>
>> diff --git a/tools/virt-pki-query-dn.c b/tools/virt-pki-query-dn.c
>> new file mode 100644
>> index 000000000000..0706256d0016
>> --- /dev/null
>> +++ b/tools/virt-pki-query-dn.c
>> @@ -0,0 +1,137 @@
>> +/*
>> + * SPDX-License-Identifier: GPL-2.0-or-later
>> + */
>> +
>> +#include <config.h>
>> +#include "internal.h"
>> +
>> +#include <err.h>
>
>This is not a standard C library API. Doesn't exist on Mingw at least
>AFAICT.
>

Ah, I should've known better:

"""
CONFORMING TO
        These functions are nonstandard BSD extensions.
"""

I'll change that to the longer version in v2, thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20211111/d41422a6/attachment-0001.sig>