[libvirt PATCH 0/2] improve audio device compat handling on migration

[Michal Prívozník]

On 11/11/21 5:35 PM, Daniel P. Berrangé wrote:
> Avoid being over-eager in stripping <audio> elements.
> 
> This still isn't ideal, because if a user happened to provide an audio
> config that *exactly* matches  the libvirt historical default we'll
> still strip it.
> 
> Thinking that maybe libvirt should advertize feature flags in te
> migration cookies.
> 
> eg if the QEMU driver on the target host reports  "explicit-audiodev",
> then te source host knows it doesn't need to strip it out to migrate
> to this host. If it doesn't report it, then it knows it must be an
> older libvirt version pre-dating audiodev.
> 
> Daniel P. Berrangé (2):
>   conf: add helper for comparing virDomainAudioDef objects
>   qemu: don't strip audio elements with user config present
> 
>  src/conf/domain_conf.c   | 144 +++++++++++++++++++++++++++++++++++++++
>  src/conf/domain_conf.h   |   3 +
>  src/libvirt_private.syms |   1 +
>  src/qemu/qemu_domain.c   |  72 +++++++++++---------
>  4 files changed, 188 insertions(+), 32 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

Michal