[libvirt PATCH 1/5] meson: Define qemu_moddir correctly

Andrea Bolognani abologna at redhat.com
Mon Nov 15 18:45:17 UTC 2021


We can't hardcode /usr here, because the user might have
configured whatever arbitrary prefix.

Everything appeared to be okay because when joining paths
Meson will drop any component that precedes an absolute path
and libdir happens to be absolute, but we should still do
things correctly instead of relying on this.

Fixes: 2ad009eadde27491ff4248f481560953776b2a87
Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
 meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meson.build b/meson.build
index dd46572365..e1e4621868 100644
--- a/meson.build
+++ b/meson.build
@@ -1681,7 +1681,7 @@ if not get_option('driver_qemu').disabled()
 
     qemu_moddir = get_option('qemu_moddir')
     if qemu_moddir == ''
-      qemu_moddir = '/usr' / libdir / 'qemu'
+      qemu_moddir = libdir / 'qemu'
     endif
     conf.set_quoted('QEMU_MODDIR', qemu_moddir)
 
-- 
2.31.1




More information about the libvir-list mailing list