[libvirt PATCH 03/11] qemu_snapshot: revert: drop unused loadvm code
Peter Krempa
pkrempa at redhat.com
Tue Nov 16 14:33:45 UTC 2021
On Tue, Nov 16, 2021 at 15:30:02 +0100, Peter Krempa wrote:
> On Mon, Nov 15, 2021 at 17:22:46 +0100, Pavel Hrdina wrote:
> > Now that we always restart QEMU process the loadvm code is unused and
> > can be dropped.
> >
> > Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> > ---
> > src/qemu/qemu_snapshot.c | 96 +++++++++++-----------------------------
> > 1 file changed, 26 insertions(+), 70 deletions(-)
> >
> > diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c
> > index 661f74146c..251a0e5cfa 100644
> > --- a/src/qemu/qemu_snapshot.c
> > +++ b/src/qemu/qemu_snapshot.c
[...]
> > /* Transitions 2, 3 */
> > - load:
>
> ... here.
>
> > was_stopped = true;
>
> Which meant that 'was_stopped' was set to true when reverting when the VM
> was killed, which is not happening after this patch.
>
> The commit message is claiming pure dead code removal, thus this must be
> fixed or justified.
Looking at the next commit it should be sufficient to add another
'was_stopped = true;' into the other branch and remove them both in the
next commit.
Reviewed-by: Peter Krempa <pkrempa at redhat.com>
More information about the libvir-list
mailing list