[RFC PATCH] tests/qemuxml2*/graphics-spice-timeout: skip CPU model check

Daniel Henrique Barboza danielhb413 at gmail.com
Wed Nov 17 11:28:36 UTC 2021



On 11/17/21 08:26, Peter Krempa wrote:
> On Wed, Nov 17, 2021 at 08:16:05 -0300, Daniel Henrique Barboza wrote:
>> On 11/17/21 08:02, Boris Fiuczynski wrote:
>>> On 11/17/21 1:11 AM, Daniel Henrique Barboza wrote:
> 
> [...]
> 
>>>> fix works for you?
>>>
>>> The proposed patch works on s390x as well.
>>>
>>> Reviewed-by: Boris Fiuczynski <fiuczy at linux.ibm.com>
>>
>>
>> Thanks for checking. I'll hold this patch a little* to see if we can fix the
>> real cause of the bug, which can be something to do with how we are defaulting
>> x86_64 cpus for ppc64 and s390x.
>>
>>
>>
>> * just a couple of days. No need to let the build being broken more than that.
> 
> I don't think that's necessary, the CPU checking is totally irrelevant
> to the test you are fixing. If you manage to fix the root cause it can
> definitely be done separately.

Boris also mentioned that this is broken since Nov 4th. I'll make the commit msg
adjustments you mentioned and push it.




> 




More information about the libvir-list mailing list