[PATCH] qemuDomainPrepareStorageSourceBlockdev: Set default encryption engine also when preparing virStorageSource

Ján Tomko jtomko at redhat.com
Thu Nov 18 09:59:44 UTC 2021


On a Tuesday in 2021, Peter Krempa wrote:
>Originally the default encryption engine is populated in the disk
>post-parse callback code. This works for disks but for any additional
>images introduced either via the block copy API or via the backup API we
>don't populate the default.
>
>In case when the backup or block copy is requested on an encrypted image
>this would then lead to an error:
>
> error: internal error: Unexpected enum value 0 for virStorageEncryptionEngine
>
>This patch adds another point where we populate the default which is
>when setting up a virStorageSource for actual usage.
>
>We keep the original setting in the post-parse callback as that's the
>only point that is recorded in the XML file after definition.
>
>Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2023674
>Fixes: ab1d46d6128
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_domain.c | 3 +++
> 1 file changed, 3 insertions(+)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20211118/fba4421a/attachment-0001.sig>


More information about the libvir-list mailing list