[PATCH 00/16] chardev handling cleanups (chardev refactors part 1)

Peter Krempa pkrempa at redhat.com
Thu Nov 18 16:33:25 UTC 2021


This is a collection of cleanup patches from my ever-growing branch
refactoring handling of chardevs in the qemu driver.

Peter Krempa (16):
  qemuBuildCommandLine: Properly check return value of
    qemuBuildShmemCommandLine
  qemu: hotplug: Add wrapper for qemuMonitorAttachCharDev
  qemuMonitorJSONAddDeviceProps: Simplify construction of the command
  qemuMonitorJSONAttachCharDevCommand: Format only the properties
  qemuMonitorJSONAttachCharDevGetProps: Simplify handling of unsupported
    types
  qemuMonitorJSONAttachCharDevGetProps: Modernize construction of JSON
    objects
  qemu: command: Rename qemuBuildHostNetStr -> qemuBuildHostNetProps
  qemuBuildChrChardevStr: Use proper type for the switch statement
  conf: Convert 'chr' in virDomainShmemDef to proper pointer
  qemuDomainAddChardevTLSObjects: Refactor cleanup
  qemuDomainEnsurePCIAddress: Don't pass virQEMUDriver explicitly
  qemuDomainAttachChrDeviceAssignAddr: Simplify return value handling
  qemuDomainAttachChrDevice: Drop 'dev' variable
  qemuBuildStorageSourceAttachPrepare(Drive|Chardev): Unexport
  conf: Properly instantiate virDomainChrSourceDef in virDomainTPMDef
  qemuxml2argvtest: Fix type for faked chardev backing a TPM

 src/conf/domain_audit.c         |   6 +-
 src/conf/domain_conf.c          |  31 +++--
 src/conf/domain_conf.h          |   6 +-
 src/qemu/qemu_cgroup.c          |   2 +-
 src/qemu/qemu_command.c         |  40 +++---
 src/qemu/qemu_command.h         |  22 ++-
 src/qemu/qemu_domain.c          |   6 +-
 src/qemu/qemu_domain_address.c  |  13 +-
 src/qemu/qemu_domain_address.h  |   8 +-
 src/qemu/qemu_hotplug.c         | 101 +++++++-------
 src/qemu/qemu_monitor_json.c    | 236 ++++++++++++++++----------------
 src/qemu/qemu_namespace.c       |   2 +-
 src/qemu/qemu_tpm.c             |  10 +-
 src/security/security_dac.c     |   6 +-
 src/security/security_selinux.c |   6 +-
 tests/qemuxml2argvtest.c        |   6 +-
 16 files changed, 250 insertions(+), 251 deletions(-)

-- 
2.31.1




More information about the libvir-list mailing list