[PATCH 15/16] conf: Properly instantiate virDomainChrSourceDef in virDomainTPMDef

Ján Tomko jtomko at redhat.com
Fri Nov 19 10:43:21 UTC 2021


On a Thursday in 2021, Peter Krempa wrote:
>'virDomainChrSourceDef' contains private data so 'virDomainChrSourceDefNew'
>must be used to allocate it. 'virDomainTPMDef' was using it directly
>which won't work with the chardev helper functions.
>
>Convert it to a pointer to properly allocate private data.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/conf/domain_audit.c         |  4 ++--
> src/conf/domain_conf.c          | 14 +++++++++-----
> src/conf/domain_conf.h          |  4 ++--
> src/qemu/qemu_cgroup.c          |  2 +-
> src/qemu/qemu_command.c         |  6 +++---
> src/qemu/qemu_namespace.c       |  2 +-
> src/qemu/qemu_tpm.c             | 10 +++++-----
> src/security/security_dac.c     |  6 +++---
> src/security/security_selinux.c |  6 +++---
> tests/qemuxml2argvtest.c        |  6 +++---
> 10 files changed, 32 insertions(+), 28 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20211119/ed967763/attachment-0001.sig>


More information about the libvir-list mailing list