[PATCH 7/7] util: Make client-side polkit work even with polkit disabled

Daniel P. Berrangé berrange at redhat.com
Mon Nov 22 09:23:01 UTC 2021


On Sun, Nov 21, 2021 at 12:10:08AM +0100, Martin Kletzander wrote:
> The reason for this is twofold:
> 
> - the polkit build option is documented for UNIX socket access checks
> 
> - there is no server-side change or dbus call done when enabling this as it only
>   starts a polkit agent on the client-side (actually only in virsh) and does not
>   need any requirements (starting is skipped if pkttyagent is not installed)
> 
> Also move the conditional implementation to the bottom of the file so that it
> does not look like the whole file is build conditionally and the common
> functions are at the top.

Does this still work correctly on Windows if we try by default ?


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list