[PATCH 07/12] virNodeDeviceCapVPDParseCustomFields: Don't use 'virXPathStringLimit'

Ján Tomko jtomko at redhat.com
Tue Nov 23 14:30:26 UTC 2021


On a Monday in 2021, Peter Krempa wrote:
>virXPathStringLimit doesn't give callers a way to differentiate between
>the queried XPath being empty and the length limit being exceeded.
>
>This means that callers are overwriting the error message.
>
>Move the length checks into the caller.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/conf/node_device_conf.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20211123/fd9a4198/attachment-0001.sig>


More information about the libvir-list mailing list