[PATCH] qemu: Remove 'else' branches after 'return' or 'goto'

Jiri Denemark jdenemar at redhat.com
Wed Nov 24 08:56:29 UTC 2021


On Tue, Nov 23, 2021 at 18:20:10 +0100, Kristina Hanicova wrote:
> I think it makes no sense to have else branches after return or
> goto as it will never reach them in cases it should not. This
> patch makes the code more readable (at least to me).
> 
> Signed-off-by: Kristina Hanicova <khanicov at redhat.com>
> ---
>  src/libvirt.c                  |  3 ++-
>  src/qemu/qemu_agent.c          |  6 +++---
>  src/qemu/qemu_alias.c          |  9 +++++----
>  src/qemu/qemu_capabilities.c   |  4 ++--
>  src/qemu/qemu_cgroup.c         |  9 +++------
>  src/qemu/qemu_conf.c           | 11 +++++------
>  src/qemu/qemu_domain_address.c | 11 +++++------
>  src/qemu/qemu_domainjob.c      |  3 +--
>  src/qemu/qemu_driver.c         | 32 ++++++++++++++++----------------
>  9 files changed, 42 insertions(+), 46 deletions(-)

Reviewed-by: Jiri Denemark <jdenemar at redhat.com>




More information about the libvir-list mailing list