[PATCH 0/2] libxl: Remove dead code

Michal Prívozník mprivozn at redhat.com
Wed Nov 24 08:58:25 UTC 2021


On 11/24/21 00:43, Jim Fehlig wrote:
> I was too lazy to dig through history, but I think 1/2 was the result
> of too much copy and paste when originally implementing jobs in the
> libxl driver. For 2/2, I think there was some ill-conceived locking of
> the libxlDomainObjPrivate in the past. Its use was killed but the
> object remained virObjectLockable.
> 
> Jim Fehlig (2):
>   libxl: Remove unused macros
>   libxl: Don't derive libxlDomainObjPrivate from virObjectLockable
> 
>  src/libxl/libxl_domain.c | 38 ++++++--------------------------------
>  src/libxl/libxl_domain.h |  7 -------
>  2 files changed, 6 insertions(+), 39 deletions(-)
> 

Funny thing is that LIBXL_JOB_ABORT which is removed in 1/2 was never
defined :-)

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

Michal




More information about the libvir-list mailing list