[PATCH v3 08/12] conf: Add a memballoon helper for future use

[Martin Kletzander]

On Wed, Nov 10, 2021 at 10:24:27PM +0800, Luke Yue wrote:
>Currently it will only be used in test driver.
>
>Signed-off-by: Luke Yue <lukedyue at gmail.com>
>---
> src/conf/domain_conf.c   | 24 ++++++++++++++++++++++++
> src/conf/domain_conf.h   |  4 ++++
> src/libvirt_private.syms |  1 +
> 3 files changed, 29 insertions(+)
>
>diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
>index 512bfab9e9..92a8bd63f3 100644
>--- a/src/conf/domain_conf.c
>+++ b/src/conf/domain_conf.c
>@@ -16998,6 +16998,30 @@ virDomainTPMDefRemove(virDomainDef *def,
> }
>
>
>+bool
>+virDomainMemballoonDefEquals(const virDomainMemballoonDef *a,
>+                             const virDomainMemballoonDef *b)

It is really weird that you picked the membaloon as that particular one
does not really make sense to be present multiple times, it is similar
to the watchdog device.  It is not a problem in this case, but I feel
like this function is a bit useless.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20211126/b96c48f5/attachment-0001.sig>