[PATCH v2 0/2] Fix /proc/*/stat parsing

Martin Kletzander mkletzan at redhat.com
Sat Nov 20 23:04:24 UTC 2021


While working on some polkit stuff I found out that we are inconsistent with the
way we parse /proc/*/stat files, so I added a new helper instead along with some
tests.  Unfortunately using it for the thing I wanted is not really viable in
the end, so it "violates" the Rule of three, but at least it does something
correctly.

v2:
- Fixed open64 by just using virFileReadAllQuiet instead of g_file_get_contents
- Removed some leftover unused variables
- Still do not know why my cirrus builds fail

v1:
- https://listman.redhat.com/archives/libvir-list/2021-November/msg00580.html

Martin Kletzander (2):
  util: Add virProcessGetStat
  Use virProcessGetStat

 src/libvirt_linux.syms                |   3 +
 src/qemu/qemu_driver.c                |  33 ++-----
 src/util/virprocess.c                 | 126 +++++++++++++++++---------
 src/util/virprocess.h                 |   4 +
 tests/meson.build                     |   1 +
 tests/virprocessstatdata/complex/stat |   2 +
 tests/virprocessstatdata/simple/stat  |   1 +
 tests/virprocessstattest.c            |  84 +++++++++++++++++
 8 files changed, 185 insertions(+), 69 deletions(-)
 create mode 100644 tests/virprocessstatdata/complex/stat
 create mode 100644 tests/virprocessstatdata/simple/stat
 create mode 100644 tests/virprocessstattest.c

-- 
2.34.0




More information about the libvir-list mailing list