[PATCH] virsh: Fix --nvram and --keep-nvram help strings

Michal Privoznik mprivozn at redhat.com
Fri Oct 1 07:05:52 UTC 2021


The --nvram and --keep-nvram options of the undefine command can
be used regardless of the domain status (the only consumer so far
- qemuDomainUndefineFlags() doesn't care about the domain
status). Yet, their corresponding help strings say something
about inactive domains while manpage says nothing. Remove the
reference to domain state.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2007659
Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 tools/virsh-domain.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 0b78fbf728..f73d9a057e 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -3595,11 +3595,11 @@ static const vshCmdOptDef opts_undefine[] = {
     },
     {.name = "nvram",
      .type = VSH_OT_BOOL,
-     .help = N_("remove nvram file, if inactive")
+     .help = N_("remove nvram file")
     },
     {.name = "keep-nvram",
      .type = VSH_OT_BOOL,
-     .help = N_("keep nvram file, if inactive")
+     .help = N_("keep nvram file")
     },
     {.name = NULL}
 };
-- 
2.32.0




More information about the libvir-list mailing list