[libvirt PATCH v5 5/7] Add PCI VPD Capability Support

Dmitrii Shcherbakov dmitrii.shcherbakov at canonical.com
Fri Oct 1 18:19:15 UTC 2021


>
> It's probably irrelevant since this will be mostly rewritten based on
> Dan's suggestions, but the resFormatFunc() pointer seems like an
> unnecessary complication - you could just move the if/else construct
> down to here and call the appropriate function directly.
>

Ack, I was trying to reuse the same parent type and a function
signature to handle resource formatting in a generic way - in case new
resource types ever got added.

But that was probably too forward-looking.




More information about the libvir-list mailing list