[PATCH 2/5] ch_monitor: Correctly close and ref the virCHMonitor

Douglas, William william.douglas at intel.com
Mon Oct 4 02:10:02 UTC 2021


On Sun, 2021-10-03 at 15:52 -0400, Laine Stump wrote:
> On 10/3/21 3:43 PM, Laine Stump wrote:
> >     cleanup:
> > +    if (mon)
> > +        virCHMonitorClose(mon);
> 
> Oops, I also meant to point out that the "if (mon)" is unnecessary
> here, 
> because (as with all similar functions in libvirt)
> virCHMonitorClose() 
> can be called with a null argument, and will just be a NOP in that
> case. 
> If you want me to split and push, I'll fix that up before pushing
> too.
> 

Ah oops, thanks for pointing that out. I'll gladly take advantage of
your offer to split them up and push, thanks!




More information about the libvir-list mailing list