[PATCH v2 1/5] qemu: add disk post parse to qemublocktest

Peter Krempa pkrempa at redhat.com
Wed Oct 6 06:52:10 UTC 2021


On Wed, Oct 06, 2021 at 08:37:16 +0200, Peter Krempa wrote:
> On Tue, Oct 05, 2021 at 09:41:12 -0500, Or Ozeri wrote:
> > The post parse callback is part of the real (non-test) processing flow.
> > This commit adds it (for disks) to the qemublocktest flow as well.
> 
> Could you please elaborate why this is needed? Specifically
> qemublocktest takes a few liberties from the "real" code flow since we
> need to fake a lot of stuff. E.g. see testQemuDiskXMLToJSONFakeSecrets.
> 
> Specifically I didn't see anything in your patches [1] which would add
> anything to the post parse callback.
> 
> 
> [1] Well after my crude rebase of the series. What you've posted didn't
> apply neither on master nor on the last release. I had to go one version
> back and it had conflicts which I didn't spend much time thinking about.

Okay I messed up the rebase and lost the hunk from patch 3.

As of such, please add a note into the commit message that it's needed
to fill in the encryption format default since we are processing old
XMLs.

Additionally please repost the patches rebased to current git master, so
that I don't have to second-guess.




More information about the libvir-list mailing list