[libvirt PATCH 14/16] qemu: use priv->logCtxt in qemuProcessLaunch
Peter Krempa
pkrempa at redhat.com
Wed Oct 6 08:42:18 UTC 2021
On Wed, Oct 06, 2021 at 09:15:20 +0200, Ján Tomko wrote:
> Remove the local variable in favor of the one stored in priv.
>
> Signed-off-by: Ján Tomko <jtomko at redhat.com>
> ---
> src/qemu/qemu_process.c | 20 +++++++++-----------
> 1 file changed, 9 insertions(+), 11 deletions(-)
>
> diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
> index 4a1fd753ee..17435c0ee9 100644
> --- a/src/qemu/qemu_process.c
> +++ b/src/qemu/qemu_process.c
[...]
>
> if (qemuProcessGenID(vm, flags) < 0)
> goto cleanup;
>
> if (qemuExtDevicesStart(driver, vm,
> - qemuDomainLogContextGetManager(logCtxt),
> + qemuDomainLogContextGetManager(priv->logCtxt),
I'm not a fan of making all the supporting processes log into the same
log file ...
> incoming != NULL) < 0)
> goto cleanup;
>
> VIR_DEBUG("Building emulator command line");
> if (!(cmd = qemuBuildCommandLine(driver,
> - qemuDomainLogContextGetManager(logCtxt),
> + qemuDomainLogContextGetManager(priv->logCtxt),
> driver->securityManager,
> vm,
.. as qemu itself, but this is prior art.
> incoming ? incoming->launchURI : NULL,
Reviewed-by: Peter Krempa <pkrempa at redhat.com>
More information about the libvir-list
mailing list