[PATCH v2 1/5] qemu: add disk post parse to qemublocktest
Peter Krempa
pkrempa at redhat.com
Wed Oct 6 09:59:09 UTC 2021
On Wed, Oct 06, 2021 at 09:55:10 +0000, Or Ozeri wrote:
> My commit which adds the encryption engine configuration is default to
> "default".
> Only in the post-parse callback in the qemu driver, I switch it from
> "default" to "qemu".
> Thus, if you don't call the post-parse on this test, then tests which use
> luks format fail.
> Specifically:
> network-qcow2-backing-chain-encryption_auth
> file-qcow2-backing-chain-encryption
> file-raw-luks
Yeah, that is okay. As noted in another reply please mention it in the
commit message, because otherwise it seems a bit misplaced. Specifically
exporting just a bit of the post-parse callbacks is questionable but
okay in this case.
And please post a rebased version as noted elsewhere.
More information about the libvir-list
mailing list