[PATCH v3 4/5] conf: add encryption engine property

Peter Krempa pkrempa at redhat.com
Thu Oct 7 12:56:26 UTC 2021


On Thu, Oct 07, 2021 at 12:41:52 +0000, Or Ozeri wrote:
>    But that means changing the input file from using the default engine, to
>    using "qemu" explicitly.
>    I was thinking that keeping the input xml unchanged gets a stronger test,
>    since it also checks that default uses qemu.

I think there's plenty of those. You are also adding one yourself in the
last patch.

>    Also since most users will still not use the new engine property, so
>    keeping the input xml unchanged also tests the more common workload.

That's happening in some of the other tests. There's no need to change
it everywhere.

For the two files which use symlinks just keep them as they are.




More information about the libvir-list mailing list