[PATCH 005/103] qemuBuildInputDevStr: Don't mix generators for -object and -device

Ján Tomko jtomko at redhat.com
Thu Oct 7 16:18:09 UTC 2021


On a Thursday in 2021, Peter Krempa wrote:
>Input devices of VIR_DOMAIN_INPUT_TYPE_EVDEV type are instantiated via
>an '-object' rather than a '-device'. Mixing them in one function is a
>bad idea as the caller then needs to use the string correctly which is
>not the case in 'qemuDomainAttachInputDevice'.
>
>Generate a JSON object for '-object' explicitly.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_command.c | 43 ++++++++++++++++++++++-------------------
> 1 file changed, 23 insertions(+), 20 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20211007/c17ead39/attachment-0001.sig>


More information about the libvir-list mailing list