[PATCH 014/103] virQEMUBuildDriveCommandlineFromJSON: Open-code in callers

Ján Tomko jtomko at redhat.com
Thu Oct 7 16:49:45 UTC 2021


On a Thursday in 2021, Peter Krempa wrote:
>Optimize the number of string copies by using the virBuffers in the
>callers directly. Simplest way to achieve this is to just open code the
>one function call 'virQEMUBuildDriveCommandlineFromJSON' was wrapping
>in the two callers.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/libvirt_private.syms |  1 -
> src/qemu/qemu_command.c  | 13 +++++++------
> src/util/virqemu.c       | 13 -------------
> src/util/virqemu.h       |  2 --
> 4 files changed, 7 insertions(+), 22 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20211007/9275ccf3/attachment-0001.sig>


More information about the libvir-list mailing list