[PATCH 037/103] qemuDeviceVideoGetModel: Clarify 'virtio' argument

Ján Tomko jtomko at redhat.com
Thu Oct 7 18:03:51 UTC 2021


On a Thursday in 2021, Peter Krempa wrote:
>The 'virito' argument was misleadingly implying that it's true for all

*virtio

>virtio devices, but that's not the case. 'virtio-vga(-gl)' is a virtio
>device but doesn't accept the usual bus-dependant suffix.
>
>Add a comment for 'qemuDeviceVideoGetModel' and another boolean
>'virtioBusSuffix' which carries the above meaning so that the 'virtio'
>argument can be fixed (it will be used later).
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_command.c | 25 ++++++++++++++++++++++---
> 1 file changed, 22 insertions(+), 3 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20211007/44bee2f4/attachment-0001.sig>


More information about the libvir-list mailing list