[PATCH 086/103] qemuBuildControllerSCSIDevStr: Format via JSON properties

Ján Tomko jtomko at redhat.com
Mon Oct 11 15:57:30 UTC 2021


On a Thursday in 2021, Peter Krempa wrote:
>Internally format the SCSI controller properties into JSON, but convert
>it back to a string so that we for now change just the SCSI controller.
>
>The change in tests is expected as the 'reg' field for a spapr-vio
>address is expected to be a number:
>
>  $ qemu-system-ppc64 -device spapr-vscsi,help
>  spapr-vscsi options:
>    reg=<uint32>           -  (default: 4294967295)
>
>The hand-rolled generator used hex representation but that will not be
>possible on the monitor via JSON.
>
>The properties of 'virtio-scsi' have following types according to QEMU:
>
>  iothread=<link<iothread>>
>  num_queues=<uint32>    -  (default: 4294967295)
>  cmd_per_lun=<uint32>   -  (default: 128)
>  max_sectors=<uint32>   -  (default: 65535)
>  ioeventfd=<bool>       - on/off (default: true)
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_command.c                       | 81 ++++++++++---------
> .../disk-scsi.x86_64-latest.args              |  2 +-
> .../pseries-vio-user-assigned.args            |  4 +-
> tests/qemuxml2argvdata/pseries-vio.args       |  4 +-
> .../tpm-emulator-spapr.ppc64-latest.args      |  4 +-
> 5 files changed, 49 insertions(+), 46 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20211011/f0be6472/attachment-0001.sig>


More information about the libvir-list mailing list