[PATCH 087/103] qemuBuildControllerPCIDevStr: Format via JSON properties

Ján Tomko jtomko at redhat.com
Mon Oct 11 16:06:22 UTC 2021


On a Thursday in 2021, Peter Krempa wrote:
>Internally format the PCI controller properties into JSON, but convert
>it back to a string so that we for now change just the SCSI controller.
>
>The change in tests is expected as the 'port' field for various PCI
>controllers is expected to be a number and thus can't be represented as
>a hexadecimal value in JSON.
>
>QEMU expects the following types:
>
>'pci-bridge'
>  chassis_nr=<uint8>     -  (default: 0)
>
>'pxb-pcie':
>  bus_nr=<uint8>         -  (default: 0)
>
>'pcie-root-port'
>  port=<uint8>           -  (default: 0)
>  chassis=<uint8>        -  (default: 0)
>  hotplug=<bool>         -  (default: true)
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_command.c                       | 99 +++++++++++++------
> ...fault-cpu-kvm-virt-4.2.aarch64-latest.args |  4 +-
> ...fault-cpu-tcg-virt-4.2.aarch64-latest.args |  4 +-
> .../qemuxml2argvdata/aarch64-pci-serial.args  |  2 +-

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20211011/bbf43118/attachment-0001.sig>


More information about the libvir-list mailing list