[PATCH v2 03/15] net/vhost-vdpa: Fix device compatibility check

Damien Hedde damien.hedde at greensocs.com
Wed Oct 13 13:30:59 UTC 2021



On 10/8/21 15:34, Kevin Wolf wrote:
> vhost-vdpa works only with specific devices. At startup, it second
> guesses what the command line option handling will do and error out if
> it thinks a non-virtio device will attach to them.
> 
> This second guessing is not only ugly, it can lead to wrong error
> messages ('-device floppy,netdev=foo' should complain about an unknown
> property, not about the wrong kind of network device being attached) and
> completely ignores hotplugging.
> 
> Drop the old checks and implement .check_peer_type() instead to fix
> this. As a nice side effect, it also removes one more dependency on the
> legacy QemuOpts infrastructure and even reduces the code size.
> 
> Signed-off-by: Kevin Wolf <kwolf at redhat.com>

Reviewed-by: Damien Hedde <damien.hedde at greensocs.com>




More information about the libvir-list mailing list