[PATCH v2 0/6] qemu_monitor_json: Assume existence of some commands

[Ján Tomko]

On a Thursday in 2021, Michal Privoznik wrote:
>Technically a v2 of:
>
>https://listman.redhat.com/archives/libvir-list/2021-October/msg00825.html
>
>but I've cancelled sending in the middle of v1. Anyway, patch 1/6 is new
>(yeah, I've noticed a test failing so I've cancelled sending v1).
>
>Michal Prívozník (6):
>  qemumigparamstest: Drop "unsupported" test case
>  qemuMonitorJSONGetMigrationParams: Don't return early on
>    CommandNotFound

qemuMonitorGetMigrationParams' comment can now lose the comment about QEMU support

>  qemuMonitorJSONGetDumpGuestMemoryCapability: Don't return early on
>    CommandNotFound
>  qemuMonitorJSONGetKVMState: Don't return early on CommandNotFound
>  qemuMonitorJSONGetMemoryDeviceInfo: Don't return early on
>    CommandNotFound

qemuDomainUpdateMemoryDeviceInfo no longer needs to consider -2 and
the comment about -2 in qemuMonitorGetMemoryDeviceInfo's description
can be dropped

>  qemuMonitorJSONGetMigrationCapabilities: Don't return early on
>    CommandNotFound
>
> src/qemu/qemu_monitor_json.c              | 23 -----------------------
> tests/qemumigparamsdata/unsupported.json  |  3 ---
> tests/qemumigparamsdata/unsupported.reply |  7 -------
> tests/qemumigparamsdata/unsupported.xml   |  4 ----
> tests/qemumigparamstest.c                 |  1 -
> 5 files changed, 38 deletions(-)
> delete mode 100644 tests/qemumigparamsdata/unsupported.json
> delete mode 100644 tests/qemumigparamsdata/unsupported.reply
> delete mode 100644 tests/qemumigparamsdata/unsupported.xml
>

Regardless of whether you squash in the above suggestions, resend them
separately or leave it up to future me:

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20211021/c9e3d202/attachment-0001.sig>