[PATCH] qemu_agent: remove unused code

Ján Tomko jtomko at redhat.com
Wed Oct 27 10:07:28 UTC 2021


On a Wednesday in 2021, Kristina Hanicova wrote:

Missing commit message.

>Signed-off-by: Kristina Hanicova <khanicov at redhat.com>
>---
> src/qemu/qemu_agent.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
>diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c
>index 5f421be6f6..f7feadd5eb 100644
>--- a/src/qemu/qemu_agent.c
>+++ b/src/qemu/qemu_agent.c
>@@ -237,17 +237,6 @@ qemuAgentIOProcessEvent(qemuAgent *agent,
>         return -1;
>     }
>
>-/*
>-    for (i = 0; i < G_N_ELEMENTS(eventHandlers); i++) {
>-        if (STREQ(eventHandlers[i].type, type)) {
>-            virJSONValue *data = virJSONValueObjectGet(obj, "data");
>-            VIR_DEBUG("handle %s handler=%p data=%p", type,
>-                      eventHandlers[i].handler, data);
>-            (eventHandlers[i].handler)(agent, data);
>-            break;
>-        }
>-    }
>-*/

This hunk was introduced by:

commit c160ce3316852a797d7b06b4ee101233866e69a9
CommitDate: 2012-01-24 12:19:51 +0100
     QEMU guest agent support

Which also added the following:

/* When you are the first to uncomment this,
  * don't forget to uncomment the corresponding
  * part in qemuAgentIOProcessEvent as well.
  *
static struct {
     const char *type;
     void (*handler)(qemuAgent *agent, virJSONValue *data);
} eventHandlers[] = {
};
*/

With that deleted as well:

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano

>     return 0;
> }
>
>-- 
>2.31.1
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20211027/170b3e51/attachment-0001.sig>


More information about the libvir-list mailing list