[PATCH 5/6] network: allow VIR_NETWORK_CREATE_VALIDATE flag

Ján Tomko jtomko at redhat.com
Thu Sep 2 15:16:38 UTC 2021


On a Thursday in 2021, Kristina Hanicova wrote:
>Signed-off-by: Kristina Hanicova <khanicov at redhat.com>
>---
> src/network/bridge_driver.c | 4 ++--
> src/test/test_driver.c      | 4 ++--
> src/vbox/vbox_network.c     | 3 ++-
> 3 files changed, 6 insertions(+), 5 deletions(-)
>
>diff --git a/src/vbox/vbox_network.c b/src/vbox/vbox_network.c
>index 2826937f81..d9402eff42 100644
>--- a/src/vbox/vbox_network.c
>+++ b/src/vbox/vbox_network.c
>@@ -386,7 +386,8 @@ vboxNetworkDefineCreateXML(virConnectPtr conn, const char *xml, bool start,
>     virNetworkPtr ret = NULL;
>     nsresult rc;
>
>-    virCheckFlags(VIR_NETWORK_DEFINE_VALIDATE, NULL);
>+    virCheckFlags(VIR_NETWORK_DEFINE_VALIDATE |
>+                  VIR_NETWORK_CREATE_VALIDATE, NULL);
>

Again, since we rely on these two flags to be the same, I'd leave this
only checking for VIR_NETWORK_DEFINE_VALIDATE.

Anyone adding asymetric flags will then do the work to split them up.

Jano

>     if (!data->vboxObj)
>         return ret;
>-- 
>2.31.1
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20210902/ccb94629/attachment-0001.sig>


More information about the libvir-list mailing list