[PATCH] qemu_driver: Don't check for g_strdup_printf() retval

[Martin Kletzander]

On Mon, Sep 06, 2021 at 03:12:59PM +0200, Michal Privoznik wrote:
>The g_strdup_printf() function can't fail really. There's no need
>to check for its return value.
>
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>

For the concept:

Reviewed-by: Martin Kletzander <mkletzan at redhat.com>

but it needs to be properly rebased as it does not apply any more.

>---
> src/qemu/qemu_driver.c | 49 +++++++++---------------------------------
> 1 file changed, 10 insertions(+), 39 deletions(-)
>
>diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
>index cbd48b1849..2ea67b941e 100644
>--- a/src/qemu/qemu_driver.c
>+++ b/src/qemu/qemu_driver.c
>@@ -2953,13 +2932,9 @@ qemuDomainSave(virDomainPtr dom, const char *path)
> static char *
> qemuDomainManagedSavePath(virQEMUDriver *driver, virDomainObj *vm)
> {
>-    char *ret;
>     g_autoptr(virQEMUDriverConfig) cfg = virQEMUDriverGetConfig(driver);
>
>-    if (!(ret = g_strdup_printf("%s/%s.save", cfg->saveDir, vm->def->name)))
>-        return NULL;
>-
>-    return ret;
>+    return g_strdup_printf("%s/%s.save", cfg->saveDir, vm->def->name);
> }
>

Extra props for this one ^^ though =D
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20210906/4b72f8fb/attachment-0001.sig>