[PATCH 2/9] ch_monitor: Make unused function static

[Daniel P. Berrangé]

On Wed, Sep 08, 2021 at 11:01:16AM -0700, William Douglas wrote:
> The virCHMonitorGet function wasn't in use and was declared as
> non-static (though not in a header file). This function isn't going to
> be used outside of the monitor though so remove the initial
> declaration and define the function to be static.
> 
> Future work should adjust this function to allow reading VM state
> needed for PTY enablement.
> 
> Signed-off-by: William Douglas <william.douglas at intel.com>
> ---
>  src/ch/ch_monitor.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/ch/ch_monitor.c b/src/ch/ch_monitor.c
> index 0f8752d1ed..b4bc10bfcf 100644
> --- a/src/ch/ch_monitor.c
> +++ b/src/ch/ch_monitor.c
> @@ -54,7 +54,6 @@ VIR_ONCE_GLOBAL_INIT(virCHMonitor);
>  
>  int virCHMonitorShutdownVMM(virCHMonitor *mon);
>  int virCHMonitorPutNoContent(virCHMonitor *mon, const char *endpoint);
> -int virCHMonitorGet(virCHMonitor *mon, const char *endpoint);
>  
>  static int
>  virCHMonitorBuildCPUJson(virJSONValue *content, virDomainDef *vmdef)
> @@ -612,7 +611,7 @@ virCHMonitorPutNoContent(virCHMonitor *mon, const char *endpoint)
>      return ret;
>  }
>  
> -int
> +static int
>  virCHMonitorGet(virCHMonitor *mon, const char *endpoint)
>  {
>      g_autofree char *url = NULL;

This patch breaks the compile because we end up with an unused static
function. It just needs to be moved a little later in the patch series.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|