[RFC REPOST 4/7] src: introduce virDomainSetFibreChannelAppid API
Pavel Hrdina
phrdina at redhat.com
Fri Sep 10 13:15:51 UTC 2021
On Fri, Sep 10, 2021 at 01:49:20PM +0200, Michal Prívozník wrote:
> On 9/9/21 6:13 PM, Pavel Hrdina wrote:
> > Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> > ---
> > include/libvirt/libvirt-domain.h | 4 +++
> > src/driver-hypervisor.h | 6 +++++
> > src/libvirt-domain.c | 44 ++++++++++++++++++++++++++++++++
> > src/libvirt_public.syms | 1 +
> > 4 files changed, 55 insertions(+)
> >
>
>
> > diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
> > index a8a386e839..f3e6854a39 100644
> > --- a/src/libvirt-domain.c
> > +++ b/src/libvirt-domain.c
> > @@ -13229,3 +13229,47 @@ virDomainStartDirtyRateCalc(virDomainPtr domain,
> > virDispatchError(conn);
> > return -1;
> > }
> > +
> > +
> > +/**
> > + * virDomainSetFibreChannelAppid:
> > + * @domain: a domain object
> > + * @appid: user provided appid string
> > + * @flags: extra flags
>
> I like the following more:
>
> * @flags: extra flags; not used yet, so callers should always pass 0
Not true, @flags are used to control if we are modifying live or config
XML.
Pavel
> > + *
> > + * Set the Fibre Channel APPID. Accepts only printable characters
> > + * and maximal length is 128 characters. To remove the APPID use
> > + * NULL as @appid value.
> > + *
> > + * Returns 0 in case of success, -1 otherwise.
> > + */
>
> Michal
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20210910/72fd0473/attachment-0001.sig>
More information about the libvir-list
mailing list