[libvirt PATCH 0/4] qemu: replace -device sga with -M graphics=off
Richard W.M. Jones
rjones at redhat.com
Mon Sep 13 09:44:01 UTC 2021
On Thu, Sep 09, 2021 at 12:25:12PM +0100, Daniel P. Berrangé wrote:
> SeaBIOS >= 1.11 / QEMU >= 2.11 no longer requires the 'sga'
> device for serial console output from the BIOS. It can be
> done directly with graphics=off machine option.
>
> This appears to be live migration compatible, despite
> changing the number of option ROMS loaded, though I need a
> little more testing to fully confirm this.
>
> Daniel P. Berrangé (4):
> qemu: prevent use of <bios useserial='yes'> on non-x86 arches
> qemu: tweak error message to be more general purpose
> qemu: switch to use -M graphics=off instead of -device sga
> qemu: stop probing for '-device sga' support
>
> src/qemu/qemu_capabilities.c | 3 +--
> src/qemu/qemu_capabilities.h | 2 +-
> src/qemu/qemu_command.c | 25 ++++++++-----------
> src/qemu/qemu_validate.c | 15 ++++++++---
> .../caps_2.11.0.x86_64.xml | 1 -
> .../caps_2.12.0.x86_64.xml | 1 -
> .../caps_3.0.0.x86_64.xml | 1 -
> .../caps_3.1.0.x86_64.xml | 1 -
> .../caps_4.0.0.x86_64.xml | 1 -
> .../caps_4.1.0.x86_64.xml | 1 -
> .../caps_4.2.0.x86_64.xml | 1 -
> .../caps_5.0.0.x86_64.xml | 1 -
> .../caps_5.1.0.x86_64.xml | 1 -
> .../caps_5.2.0.x86_64.xml | 1 -
> .../caps_6.0.0.x86_64.xml | 1 -
> .../caps_6.1.0.x86_64.xml | 1 -
> tests/qemuxml2argvdata/bios.args | 3 +--
> tests/qemuxml2argvtest.c | 3 +--
> 18 files changed, 25 insertions(+), 38 deletions(-)
I didn't test it, but the changes look reasonable so:
Reviewed-by: Richard W.M. Jones <rjones at redhat.com>
Equivalent (non-)change to libguestfs is:
https://github.com/libguestfs/libguestfs/commit/e14ff937422115e23094ca4cce80ec9fb01c10b3
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top
More information about the libvir-list
mailing list