[libvirt PATCH 0/3] Reduce stack frame size of virNWFilterRuleDefFixup

Daniel P. Berrangé berrange at redhat.com
Fri Sep 17 13:10:06 UTC 2021


On Fri, Sep 17, 2021 at 02:58:08PM +0200, Tim Wiederhake wrote:
> When libvirt is build with sanitizers enabled, in debug mode, on clang,
> virNWFilterRuleDefFixup exceeds the maximum stack frame size of 8192 bytes,
> as specified in meson.build:
> 
>   ../src/conf/nwfilter_conf.c:2190:1: error: stack frame size of 10616
>   bytes in function 'virNWFilterRuleDefFixup' [-Werror,-Wframe-larger-than=]
>   virNWFilterRuleDefFixup(virNWFilterRuleDef *rule)
>   ^
>   1 error generated.
> 
> This series reworks the function a bit to bring the frame size below 8192.

Why don't we just enlarge stack size limit for building with
sanitizers ?


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list