[PATCH 00/14] qemu: more 'query-command-line-options' cleanups

Ján Tomko jtomko at redhat.com
Mon Sep 20 16:36:25 UTC 2021


On a Monday in 2021, Peter Krempa wrote:
>In a private conversation Markus dug out the history of certain of the
>flags we probe via 'query-command-line-options'. I already had some
>patches for this but without the history or justification.
>
>To prevent us going through this again I've decided to send some more
>removal of capability bits based on stuff that all qemu's we support
>have.
>
>Peter Krempa (14):
>  qemu: command: Always assume 'QEMU_CAPS_BOOT_STRICT'
>  qemu: capabilities: Retire QEMU_CAPS_BOOT_STRICT
>  tests: qemuxml2argv: Remove negative case for 'reboot-timeout-enabled'
>  qemu: Always assume QEMU_CAPS_REBOOT_TIMEOUT
>  qemu: capabilities: Retire QEMU_CAPS_REBOOT_TIMEOUT
>  qemuxml2argvtest: Remove negative case for
>    'boot-menu-enable-with-timeout'
>  qemu: Always assume QEMU_CAPS_SPLASH_TIMEOUT
>  qemu: capabilities: Retire QEMU_CAPS_SPLASH_TIMEOUT
>  qemu: Always assume QEMU_CAPS_MEM_MERGE
>  qemu: capabilities:  QEMU_CAPS_MEM_MERGE
>  qemu: capabilities: Assume QEMU_CAPS_AES_KEY_WRAP and
>    QEMU_CAPS_DEA_KEY_WRAP for s390 only
>  qemu: capabilities: Assume QEMU_CAPS_LOADPARM for s390 only
>  qemu: Assume QEMU_CAPS_FW_CFG
>  qemu: capabilities: Retire QEMU_CAPS_FW_CFG
>
> src/qemu/qemu_capabilities.c                  | 27 ++++++------
> src/qemu/qemu_capabilities.h                  | 10 ++---
> src/qemu/qemu_command.c                       | 10 ++---
> src/qemu/qemu_validate.c                      | 42 ++-----------------
> .../caps_2.11.0.s390x.xml                     |  5 ---

[...]

> tests/qemuxml2argvdata/watchdog-dump.args     |  1 +
> .../qemuxml2argvdata/watchdog-injectnmi.args  |  1 +
> tests/qemuxml2argvdata/watchdog.args          |  1 +
> tests/qemuxml2argvdata/x86-kvm-32-on-64.args  |  1 +
> tests/qemuxml2argvtest.c                      | 17 +++-----
> tests/qemuxml2xmltest.c                       |  8 ++--
> 609 files changed, 596 insertions(+), 390 deletions(-)
> delete mode 100644 tests/qemuxml2argvdata/boot-menu-enable-with-timeout.err
> delete mode 100644 tests/qemuxml2argvdata/reboot-timeout-enabled.err
>

Thank you.

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20210920/fe76c7b2/attachment-0001.sig>


More information about the libvir-list mailing list