[PATCH v2 1/2] virsh: domain: fix mistake in cmdMigrateSetMaxDowntime()

Kristina Hanicova khanicov at redhat.com
Thu Sep 23 23:30:48 UTC 2021


Function returned false when everything ended successfully, there
was a missing check for a return value. This patch fixes that.

Signed-off-by: Kristina Hanicova <khanicov at redhat.com>
---
 tools/virsh-domain.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index f876f30cc5..2730acfba5 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -11018,7 +11018,7 @@ cmdMigrateSetMaxDowntime(vshControl *ctl, const vshCmd *cmd)
         goto done;
     }
 
-    if (virDomainMigrateSetMaxDowntime(dom, downtime, 0))
+    if (virDomainMigrateSetMaxDowntime(dom, downtime, 0) < 0)
         goto done;
 
     ret = true;
-- 
2.31.1




More information about the libvir-list mailing list