[PATCH] vsh: Don't check for OOM in vshGetTypedParamValue()

Ján Tomko jtomko at redhat.com
Fri Sep 24 10:29:22 UTC 2021


On a Friday in 2021, Michal Privoznik wrote:
>Both function description and function itself mention check for
>OOM which can't happen really. There was a bug in glib where
>g_strdup_*() might have not aborted on OOM, but we have our own
>implementation when dealing with broken glib (see
>vir_g_strdup_printf()). Therefore, checking for OOM is redundant
>and can never be true.
>
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> tools/vsh.c | 25 +++++++++----------------
> 1 file changed, 9 insertions(+), 16 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20210924/92a1277a/attachment-0001.sig>


More information about the libvir-list mailing list