[PATCH v4 3/4] qemu: command: add support to enable/disable hotplug on pci-root controller

[Laine Stump]

On 9/27/21 12:54 AM, Ani Sinha wrote:
> 
> 
> On Sun, 26 Sep 2021, Laine Stump wrote:
>>
>>> +            QEMU_CAPS_PIIX_ACPI_ROOT_PCI_HOTPLUG);
>>> +    DO_TEST_PARSE_ERROR_NOCAPS("pc-i440fx-acpi-root-hotplug-enable");
>>
>> Ah, now I understand the origin of pc-i440fx-acpi-root-hotplug-enable.xml in
>> the previous patch - you had created it to be test case  for this negative
>> test. Actually I think the negative test should be done using the ...-disable
>> test case with no caps; in the case that someone has "hotplug='on'" and the
>> option is missing, I think we should just ignore it, since "hotplug='on'" is
>> what they're going to get anyway (that could be added into the validation that
>> was added in the previous patch). You still you add the -enable test case to
>> qemuxml2xmltest.c as I suggested in the previous patch.
> 
> No. Lets make hotplug=on/off explicit either way. Qemu defaults keep
> changing :-)

Yes, now that there is a settable property its default can be changed, 
but we do know that on all versions of QEMU that don't support setting 
this property, hotplug is always enabled for pci-root. Anyway, this 
isn't important - we can always relax it later if someone really wants it.