[PATCH 0/1] vmx: Fix <genid/> mapping
Richard W.M. Jones
rjones at redhat.com
Wed Sep 29 09:57:19 UTC 2021
Looking at the qemu code the problem IMHO is:
https://gitlab.com/qemu-project/qemu/-/blob/6b54a31bf7b403672a798b6443b1930ae6c74dea/docs/specs/vmgenid.txt#L189
https://gitlab.com/qemu-project/qemu/-/blob/6b54a31bf7b403672a798b6443b1930ae6c74dea/hw/acpi/vmgenid.c#L37
This byte swapping makes no sense to me. How do we know that the
guest is little endian? What will this code do for BE guests? I
think qemu would be better off treating the "GUID" as a list of bytes
and writing that exactly into the guest memory.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html
More information about the libvir-list
mailing list