[libvirt PATCH] util: Fix stubs for virProcessGet{Stat,Sched}Info()

Ján Tomko jtomko at redhat.com
Tue Apr 19 07:52:53 UTC 2022


On a Friday in 2022, Andrea Bolognani wrote:
>Commit d73852c49962 moved the original QEMU-specific helpers to
>the utils module, which resulted in build failures on non-Unix
>platforms due to the unconditional use of Unix-only symbols such
>as _SC_CLK_TCK.
>
>To deal with that situation, commit d7c64453aa0e made the helpers
>Linux-only and added stubs for other platforms that, when called,
>would always fail with ENOSYS.
>
>However the original helpers had been carefully written so that,
>while they would only be able to produce useful output on Linux,
>they would still succeed on the other Unix platforms where we
>build the QEMU driver.
>
>Restore the original behavior so that calling APIs such as
>virDomainGetInfo() can once again work on FreeBSD and macOS.
>
>Resolves: https://gitlab.com/libvirt/libvirt/-/issues/298
>Signed-off-by: Andrea Bolognani <abologna at redhat.com>
>---
>Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/517776953
>
> src/util/virprocess.c | 29 ++++++++++++++++++++---------
> 1 file changed, 20 insertions(+), 9 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20220419/b1ab847f/attachment.sig>


More information about the libvir-list mailing list